-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 'golang.org/x/exp/slices' dependencies #5567
fix 'golang.org/x/exp/slices' dependencies #5567
Conversation
Skipping CI for Draft Pull Request. |
/hold, wait to upgrade for go 1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Leaving my LGTM in advance, but am thinking that perhaps we could apply a go work sync
separately?
It appears we have a bunch of dependencies that could be version bumped.
b6c1121
to
86d7a3c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: koba1t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That makes sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
86d7a3c
to
75d618e
Compare
75d618e
to
72f0a3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold
golang.org/x/exp
module was added in unwanted-dependencies in k/k.https://github.com/kubernetes/kubernetes/pull/118339/files#diff-09f70f26cff6c34dc0063a45ca43cf5025d653058b06f7966fc8e6f3b9cecd3eR64