-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a local test server instead of example.com #5624
Conversation
/assign @koba1t |
/lgtm
Perhaps we should resort to using an API mocker (like wiremock) to respond
something predictable instead.
|
@karlkfi looks like it's failing tests because the address is returning HTTP status code 404 now 😅 |
057b69d
to
b6245c6
Compare
Replaced with a local test server. |
b6245c6
to
38ad0b9
Compare
38ad0b9
to
593ffc8
Compare
593ffc8
to
9db92fd
Compare
Tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @koba1t
for maintainer review
Thanks @karlkfi |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karlkfi, koba1t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
example.com was returning 500 for a while instead of 404 and causing the tests to fail.
So use a local test server instead.