Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close dir #5655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: close dir #5655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmd/pluginator/internal/krmfunction/converter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ func (c *Converter) readDiskFile(path string) (string, error) {
func (c *Converter) mkDstDir() error {
p := c.outputDir
f, err := os.Open(p)
if f != nil {
f.Close()
}

Comment on lines 149 to +153
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the only purpose for this os.Open() call is to check whether the folder already exists. Since this is the case, I believe it would be better to use os.Stat() here instead of os.Open().

if err == nil || f != nil {
return fmt.Errorf("directory %s has already existed", p)
}
Expand Down