-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include label in templates when adding by cli #5682
fix: include label in templates when adding by cli #5682
Conversation
Welcome @kozjan! |
Hi @kozjan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, @kozjan! 👋🏻
Thank you for your contribution!
This looks mostly good to me. However, this implementation requires --without-selector
to be specified and there's no added validation for that. Could you please update validateAndParse
to ensure that any invocation of kustomize edit add label --include-templates
fails when --without-selector
is not specified, as well as an extra test case for that scenario?
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@stormqueen1990 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
/ok-to-test |
/easycla |
Hi there, @kozjan! It looks like there was a lint failure, could you please take a look at that? It also seems like EasyCLA couldn't pick up the commit identity correctly for the commit made via GitHub CLI. It might be a good idea to squash the commits and see if that works. |
c85ee43
to
cba3688
Compare
hey @stormqueen1990, sorry for getting back so late |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me!
/lgtm
/approve
@stormqueen1990 could you please add a lgtm before merging?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kozjan, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related to this comment: #1009 (comment)
added
--include-templates
to add labels to templates when usingkustomize edit add label