-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --force flag to modify annotations and labels #950
Add --force flag to modify annotations and labels #950
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
e7c19bd
to
c7b8413
Compare
/check-cla |
1 similar comment
/check-cla |
c7b8413
to
f0065f6
Compare
This change adds a new flag (`--force`) to commands `edit add annotation` and `edit add label` so that annotations and labels are modified if they already existed.
f0065f6
to
2cf8371
Compare
@2opremio Thank you for working on this. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2opremio, Liujingfang1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change adds a new flag (
--force
) to commandsedit add annotation
andedit add label
so that annotations and labels are modified if they already existed.Fixes #564