Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Supports configuration of node heartbeat interval #251

Closed
wzshiming opened this issue Feb 2, 2023 · 3 comments · Fixed by #403
Closed

[kwokctl] Supports configuration of node heartbeat interval #251

wzshiming opened this issue Feb 2, 2023 · 3 comments · Fixed by #403
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@wzshiming
Copy link
Member

wzshiming commented Feb 2, 2023

What would you like to be added?

Passing duration to kube-controller-manager and the default node stages

Why is this needed?

After creating 5000 nodes, the CPU load of each component spiked, mainly because the heartbeat frequency was too high, so we needed to reduce the CPU load.

@wzshiming wzshiming added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 2, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in KWOK Tracking Feb 3, 2023
@wzshiming wzshiming added this to the v0.2 milestone Feb 6, 2023
@wzshiming
Copy link
Member Author

/triage accepted
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@wzshiming:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 7, 2023
@carlory
Copy link
Member

carlory commented Feb 10, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants