Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix featureGates and runtimeConfig on kind runtime #440

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Mar 31, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix featureGates and runtimeConfig on kind runtime 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 31, 2023
@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit 18e3c91
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6426a8d42c906a00076e5fee
😎 Deploy Preview https://deploy-preview-440--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot requested a review from yibozhuang March 31, 2023 09:33
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2023
@wzshiming wzshiming merged commit 9fba042 into kubernetes-sigs:main Mar 31, 2023
@wzshiming wzshiming deleted the fix/kind-args branch March 31, 2023 11:32
wzshiming added a commit that referenced this pull request Apr 17, 2023
…upstream-release-0.1

Automated cherry pick of #440: Fix featureGates and runtimeConfig on kind runtime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants