Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shfmt to format shell scripts #514

Merged
merged 1 commit into from
Apr 19, 2023
Merged

add shfmt to format shell scripts #514

merged 1 commit into from
Apr 19, 2023

Conversation

Zhuzhenghao
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

add shfmt to format shell scripts

Which issue(s) this PR fixes:

Fixes #494

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2023
@netlify
Copy link

netlify bot commented Apr 17, 2023 •
edited
Loading

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 77084da
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/643f9079e61b4c000858de9c

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 17, 2023
wzshiming
wzshiming reviewed Apr 17, 2023
View reviewed changes
hack/update-shell-format.sh Outdated Show resolved Hide resolved
hack/verify-shell-format.sh Outdated Show resolved Hide resolved
hack/verify-shell-format.sh Outdated Show resolved Hide resolved
hack/update-shell-format.sh Outdated Show resolved Hide resolved
wzshiming
wzshiming reviewed Apr 18, 2023
View reviewed changes
hack/update-shell-format.sh Show resolved Hide resolved
hack/verify-shell-format.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2023
@Zhuzhenghao Zhuzhenghao force-pushed the shelllint branch 3 times, most recently from 051ea60 to da066ed Compare April 18, 2023 07:31
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2023
@Zhuzhenghao Zhuzhenghao force-pushed the shelllint branch 2 times, most recently from a0fdfe6 to 25aa299 Compare April 18, 2023 08:48
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2023
@Zhuzhenghao Zhuzhenghao force-pushed the shelllint branch 2 times, most recently from 99f5820 to 7e8e44f Compare April 18, 2023 09:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2023
wzshiming
wzshiming approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 19, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 19, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@Zhuzhenghao
Copy link
Contributor Author

/remove-label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 19, 2023
@wzshiming
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming, Zhuzhenghao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e2f2bad into kubernetes-sigs:main Apr 19, 2023
@wzshiming wzshiming mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzshiming wzshiming wzshiming approved these changes

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees

@wzshiming wzshiming

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shell format
3 participants
@Zhuzhenghao @wzshiming @k8s-ci-robot