Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Suppress downloading binaries when --disable-kube* is specified #549

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

Huang-Wei
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #548

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix an issue that kwokctl doesn't honor `--disable-kube*` parameter properly.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 26, 2023
@Huang-Wei Huang-Wei requested a review from wzshiming April 26, 2023 01:23
@k8s-ci-robot k8s-ci-robot requested a review from yibozhuang April 26, 2023 01:23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 26, 2023
@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit def68e2
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6448c252cfd0fd000814d52b

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2023
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Huang-Wei,wzshiming]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@Huang-Wei
Copy link
Contributor Author

@wzshiming the CI failure

docker manifest inspect docker.io/klakegg/hugo:0.107.0-ext
Get "https://registry-1.docker.io/v2/klakegg/hugo/manifests/0.107.0-ext": unknown: requesting higher privileges than access token allows
make: *** [Makefile:43: check-image-version] Error 1
make: Leaving directory '/home/runner/work/kwok/kwok/site'

popped out consistently. Are you aware of this error?

@wzshiming
Copy link
Member

#551

It looks like github action upgraded docker and it has a behavior change. I sent a PR to fix this.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@wzshiming
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 75af3f1 into kubernetes-sigs:main Apr 26, 2023
wzshiming added a commit that referenced this pull request Apr 26, 2023
…upstream-release-0.2

Automated cherry pick of #549: Suppress downloading binaries when `--disable-kube*` is
@Huang-Wei Huang-Wei deleted the fix-548 branch April 26, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--disable-kube-controller-manager and --disable-kube-scheduler should suppress downloading binaries
3 participants