Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node lease controller #587

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented May 11, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #375

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add node lease controller

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 748488b
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/64664095cd5e6400082da66e

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 11, 2023
@wzshiming wzshiming force-pushed the feat/lease branch 21 times, most recently from df5bae2 to 22dabb4 Compare May 11, 2023 08:49
@wzshiming wzshiming changed the title Add node lease controller [WIP] Add node lease controller May 16, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2023
@wzshiming wzshiming force-pushed the feat/lease branch 21 times, most recently from eaf3df3 to 0c59ad2 Compare May 18, 2023 02:11
@wzshiming wzshiming changed the title [WIP] Add node lease controller Add node lease controller May 18, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2023
@wzshiming wzshiming merged commit 8ae5fdb into kubernetes-sigs:main May 23, 2023
@wzshiming wzshiming deleted the feat/lease branch May 23, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kwok] Heartbeats lease objects within the kube-node-lease namespace
2 participants