feat: support --page-size and --page-buffer-size for snapshot export
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… k8s and snapshot export Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
… k8s and snapshot export Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
k8s-ci-robot
added
the
kind/feature
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for k8s-kwok canceled.
|
k8s-ci-robot
added
the
size/M
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
It looks like the CI cluster is abnormal |
|
@wzshiming It seems that there's a problem in |
|
Yep, It is. |
wzshiming
reviewed
May 30, 2023
AhmedGrati
force-pushed
the
feat-support-pagesize-and-pagebuffersize
branch
3 times, most recently
from
26054f1 to
1f81572
Compare
wzshiming
reviewed
May 30, 2023
AhmedGrati
force-pushed
the
feat-support-pagesize-and-pagebuffersize
branch
2 times, most recently
from
8ce9a0e to
3b1c2e7
Compare
Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>
AhmedGrati
force-pushed
the
feat-support-pagesize-and-pagebuffersize
branch
from
3b1c2e7 to
ff50e6c
Compare
wzshiming
approved these changes
May 31, 2023
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
wzshiming
changed the title
-page-size and page-buffer-size for snapshot export and save--page-size and --page-buffer-size for snapshot export and save
|
/lgtm still Thanks. |
AhmedGrati
changed the title
--page-size and --page-buffer-size for snapshot export and save--page-size and --page-buffer-size for snapshot export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds the support of
-page-sizeand-page-buffer-sizewhen executingkowkctl snapshot exportPreviously, the list pager had the default page size of
500and10as the default page buffer size. Therefore, this PR aims to introduce the tuning of these parameters to users, so they can adjust them accordingly to their needs, which can increase the performance in some cases.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: