Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag --disable-qps-limits #625

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

Zhuzhenghao
Copy link
Contributor

@Zhuzhenghao Zhuzhenghao commented May 30, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #562

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Add flag --disable-qps-limits

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2023
@k8s-ci-robot k8s-ci-robot requested a review from Huang-Wei May 30, 2023 10:18
@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit a265194
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6488403b41e2d40008d2e85e

@k8s-ci-robot k8s-ci-robot requested a review from yibozhuang May 30, 2023 10:18
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 30, 2023
@Zhuzhenghao Zhuzhenghao force-pushed the feature/qps branch 12 times, most recently from 4306f6a to b7d401a Compare June 1, 2023 13:42
pkg/kwokctl/runtime/kind/kind.go Outdated Show resolved Hide resolved
pkg/kwokctl/runtime/kind/kind.go Outdated Show resolved Hide resolved
@Zhuzhenghao Zhuzhenghao force-pushed the feature/qps branch 4 times, most recently from bd02559 to 554d53b Compare June 5, 2023 01:56
pkg/consts/consts.go Outdated Show resolved Hide resolved
pkg/kwokctl/runtime/kind/kind.go Outdated Show resolved Hide resolved
@Zhuzhenghao Zhuzhenghao force-pushed the feature/qps branch 4 times, most recently from 82506a0 to 20a2a8d Compare June 12, 2023 08:44
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2023
@Zhuzhenghao Zhuzhenghao force-pushed the feature/qps branch 2 times, most recently from e3f8e00 to eb61f23 Compare June 13, 2023 02:13
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@Zhuzhenghao Zhuzhenghao force-pushed the feature/qps branch 6 times, most recently from cce4c57 to fe3dfc2 Compare June 13, 2023 09:52
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming, Zhuzhenghao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit c328db5 into kubernetes-sigs:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kwokctl] Supports disabling all QPS limits
3 participants