Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kwokctl] Fix binary runtime on windows #646

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[kwokctl] Fix binary runtime on windows #646

merged 1 commit into from
Jul 6, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jun 12, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref #648

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Fix binary runtime on windows

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 12, 2023
@netlify
Copy link

netlify bot commented Jun 12, 2023 •
edited
Loading

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 92c0225
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/64a597f212087d0008fff15d

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 12, 2023
@wzshiming wzshiming force-pushed the feat/windows-binary branch from 97efbe8 to 5fce81e Compare June 19, 2023 14:19
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 19, 2023
@wzshiming wzshiming force-pushed the feat/windows-binary branch from 5fce81e to cf42e6a Compare June 21, 2023 01:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2023
@wzshiming wzshiming force-pushed the feat/windows-binary branch from cf42e6a to 4667f61 Compare June 27, 2023 02:38
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2023
@wzshiming wzshiming force-pushed the feat/windows-binary branch from ce56acd to 75ed19b Compare June 29, 2023 05:04
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 29, 2023
@wzshiming wzshiming changed the title [WIP][kwokctl] Support windows binary [WIP][kwokctl] Fix and test binary runtime on windows Jun 29, 2023
@wzshiming wzshiming changed the title [WIP][kwokctl] Fix and test binary runtime on windows [WIP][kwokctl] Fix binary runtime on windows Jun 29, 2023
@wzshiming wzshiming force-pushed the feat/windows-binary branch 7 times, most recently from 60c26af to cc65286 Compare June 30, 2023 21:21
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@wzshiming wzshiming force-pushed the feat/windows-binary branch from cc65286 to 4cb9044 Compare July 4, 2023 02:03
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2023
@wzshiming wzshiming force-pushed the feat/windows-binary branch 4 times, most recently from 5138f4b to 7f367ee Compare July 4, 2023 05:47
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2023
@wzshiming wzshiming force-pushed the feat/windows-binary branch 4 times, most recently from 584fb3f to e7e038f Compare July 5, 2023 11:06
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023
@wzshiming wzshiming force-pushed the feat/windows-binary branch 6 times, most recently from d8719a6 to 5153aa2 Compare July 5, 2023 15:07
@wzshiming wzshiming force-pushed the feat/windows-binary branch from 5153aa2 to 92c0225 Compare July 5, 2023 16:18
@wzshiming wzshiming changed the title [WIP][kwokctl] Fix binary runtime on windows [kwokctl] Fix binary runtime on windows Jul 6, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2023
@wzshiming wzshiming merged commit ef999cc into kubernetes-sigs:main Jul 6, 2023
@wzshiming wzshiming deleted the feat/windows-binary branch July 6, 2023 01:24
@wzshiming wzshiming mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzshiming @k8s-ci-robot