Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support CRD for stage #692

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Support CRD for stage #692

merged 1 commit into from
Jul 5, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jun 29, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref #264
Fixed #656

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support CRD for stage

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 29, 2023
@netlify
Copy link

netlify bot commented Jun 29, 2023 •
edited
Loading

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit e0afbd0
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/64a3cc63a2fc150008d20e96

@k8s-ci-robot k8s-ci-robot requested a review from Huang-Wei June 29, 2023 08:42
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from yibozhuang June 29, 2023 08:42
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 29, 2023
@wzshiming wzshiming mentioned this pull request Jun 29, 2023
Closed
4 tasks
@wzshiming wzshiming force-pushed the feat/crd-stage branch 2 times, most recently from 2b2e477 to 008b25e Compare June 29, 2023 09:28
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 29, 2023
@wzshiming wzshiming force-pushed the feat/crd-stage branch 3 times, most recently from 487bdc4 to e27457c Compare June 29, 2023 14:15
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 29, 2023
@wzshiming wzshiming force-pushed the feat/crd-stage branch 6 times, most recently from a924f23 to 879eed0 Compare June 30, 2023 06:17
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 30, 2023
@wzshiming wzshiming force-pushed the feat/crd-stage branch 3 times, most recently from 2b4f1c1 to 8bb904f Compare June 30, 2023 11:21
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 30, 2023
@wzshiming wzshiming force-pushed the feat/crd-stage branch 5 times, most recently from 79452f1 to 9385464 Compare July 3, 2023 10:39
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 3, 2023
@wzshiming wzshiming changed the title Support CRD for stage [WIP] Support CRD for stage Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@wzshiming wzshiming force-pushed the feat/crd-stage branch 2 times, most recently from 91f68db to 8f309fd Compare July 4, 2023 07:06
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2023
@wzshiming wzshiming force-pushed the feat/crd-stage branch 2 times, most recently from ac14e5d to 01c4673 Compare July 4, 2023 07:29
@wzshiming wzshiming changed the title [WIP] Support CRD for stage Support CRD for stage Jul 5, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@wzshiming wzshiming merged commit 8e79793 into kubernetes-sigs:main Jul 5, 2023
@wzshiming wzshiming deleted the feat/crd-stage branch July 5, 2023 02:11
@wzshiming wzshiming mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide option to configure the "KwokConfiguration" for "kwok in cluster".
2 participants
@wzshiming @k8s-ci-robot