Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting the config and CRD checks #703

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jul 5, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

A Kind can only be configured from --config or CRD.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2023
@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 3148782
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/64a50f5d08291200086d7a64

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 5, 2023
@wzshiming wzshiming force-pushed the feat/config-and-crd branch 2 times, most recently from 331394a to baab3be Compare July 5, 2023 04:07
@wzshiming wzshiming force-pushed the feat/config-and-crd branch from baab3be to 3148782 Compare July 5, 2023 06:36
@wzshiming wzshiming merged commit 662c195 into kubernetes-sigs:main Jul 5, 2023
@wzshiming wzshiming deleted the feat/config-and-crd branch July 5, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants