Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Integrate metrics-server #734

Merged

Conversation

wzshiming
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #480

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Integrate metrics-server

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit cbccd06
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/65b0b967003407000924f8bf

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2023
@wzshiming wzshiming changed the title [kwokctl] Integrate metrics-server [WIP] [kwokctl] Integrate metrics-server Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2023
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch 2 times, most recently from b542c72 to 5242d36 Compare July 21, 2023 07:34
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2023
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch 5 times, most recently from 4aa71e9 to fb966c8 Compare July 21, 2023 08:44
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 21, 2023
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch 6 times, most recently from 9cc3258 to 38fe5bf Compare July 21, 2023 11:01
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 8, 2023
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch from 0b81456 to f32fb2c Compare December 8, 2023 09:14
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch from f32fb2c to ebff845 Compare December 12, 2023 06:27
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2024
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch from ebff845 to 8faf701 Compare January 17, 2024 12:55
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2024
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch 5 times, most recently from 749b737 to d123cc5 Compare January 24, 2024 03:23
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2024
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch 2 times, most recently from b9e74d7 to 3082b13 Compare January 24, 2024 03:49
@wzshiming wzshiming changed the title [WIP] [kwokctl] Integrate metrics-server [kwokctl] Integrate metrics-server Jan 24, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2024
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch 3 times, most recently from 411d021 to 8e45b8b Compare January 24, 2024 06:30
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2024
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch 2 times, most recently from 9073767 to 53f3876 Compare January 24, 2024 07:12
@wzshiming wzshiming force-pushed the feat/integrate-metrics-server branch from 53f3876 to cbccd06 Compare January 24, 2024 07:16
@wzshiming wzshiming merged commit d2519e4 into kubernetes-sigs:main Jan 24, 2024
28 of 29 checks passed
@wzshiming wzshiming deleted the feat/integrate-metrics-server branch January 24, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kwokctl] Integrate metrics-server
2 participants