Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Add hack subcommand for etcd operation #859

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Dec 4, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Modify etcd data directly bypass apiserver, just as kubectl does with apiserver

Add 3 subcommand

kwokctl hack get
kwokctl hack delete
kwokctl hack put

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add kwokctl hack subcommand for etcd

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Dec 4, 2023
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit f89a31c
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/659d310d7a5d790008560e9e

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 4, 2023
@wzshiming wzshiming force-pushed the feat/hack-etcd branch 11 times, most recently from 209fd0f to 68a1c2e Compare December 5, 2023 10:09
@wzshiming wzshiming force-pushed the feat/hack-etcd branch 8 times, most recently from a060cf6 to 64e59e4 Compare December 8, 2023 08:40
@wzshiming wzshiming force-pushed the feat/hack-etcd branch 2 times, most recently from e463da0 to 47e6640 Compare December 12, 2023 10:06
@wzshiming wzshiming force-pushed the feat/hack-etcd branch 4 times, most recently from 61c3d2c to 3c639dc Compare December 25, 2023 09:17
@wzshiming wzshiming changed the title Add kwokctl hack subcommand for etcd [kwokctl] Add hack subcommand for etcd operation Dec 25, 2023
@wzshiming wzshiming force-pushed the feat/hack-etcd branch 2 times, most recently from 4009f34 to efdba8c Compare December 28, 2023 03:07
@wzshiming wzshiming force-pushed the feat/hack-etcd branch 2 times, most recently from e0f4443 to ed146ba Compare January 9, 2024 04:06
@wzshiming wzshiming merged commit b4864f5 into kubernetes-sigs:main Jan 15, 2024
28 of 30 checks passed
@wzshiming wzshiming deleted the feat/hack-etcd branch January 15, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants