Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the logic of the node leases #899

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix the logic of the node leases #899

merged 1 commit into from
Jan 2, 2024

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Dec 29, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref #886

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix the logic of the node leases

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Dec 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify Netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit d2c92ea
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/6593a450e1401900088561cc
😎 Deploy Preview https://deploy-preview-899--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 29, 2023
@wzshiming wzshiming changed the title Fix failure to update the lease and no longer update Fix the logic of the node leases Dec 29, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 29, 2023
@wzshiming wzshiming force-pushed the fix/node-lease branch 7 times, most recently from 648bad9 to f804c54 Compare December 29, 2023 17:57
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 29, 2023
@wzshiming wzshiming changed the title Fix the logic of the node leases [WIP] Fix the logic of the node leases Dec 30, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2023
@wzshiming wzshiming force-pushed the fix/node-lease branch 5 times, most recently from 9e1a13e to c4962b4 Compare January 2, 2024 01:52
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 2, 2024
@wzshiming wzshiming changed the title [WIP] Fix the logic of the node leases Fix the logic of the node leases Jan 2, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2024
@wzshiming wzshiming merged commit f49ab91 into kubernetes-sigs:main Jan 2, 2024
28 of 29 checks passed
@wzshiming wzshiming deleted the fix/node-lease branch January 2, 2024 07:57
@wzshiming wzshiming mentioned this pull request Jan 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzshiming @k8s-ci-robot