Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] add --heartbeat-factor for cluster creation parameters #933

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

wzshiming
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] add --heartbeat-factor for cluster creation parameters

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 29, 2024
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit c3f4f3c
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/65b9fb1cec83710008fb9789

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 29, 2024
@wzshiming wzshiming force-pushed the feat/heartbeat-factor branch 2 times, most recently from 14f6af9 to 919e1f5 Compare January 29, 2024 07:48
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2024
@wzshiming wzshiming force-pushed the feat/heartbeat-factor branch from 919e1f5 to a220239 Compare January 29, 2024 08:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2024
@wzshiming wzshiming force-pushed the feat/heartbeat-factor branch from a220239 to dc25054 Compare January 29, 2024 08:56
@wzshiming wzshiming changed the title kwokctl: add --heartbeat-factor for cluster creation parameters [kwokctl] add --heartbeat-factor for cluster creation parameters Jan 30, 2024
@wzshiming wzshiming force-pushed the feat/heartbeat-factor branch 6 times, most recently from 140fd56 to a08cead Compare January 31, 2024 02:59
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2024
@wzshiming wzshiming force-pushed the feat/heartbeat-factor branch from a08cead to b55197c Compare January 31, 2024 04:05
@wzshiming wzshiming force-pushed the feat/heartbeat-factor branch from b55197c to c3f4f3c Compare January 31, 2024 07:47
@wzshiming wzshiming merged commit 68c18ae into kubernetes-sigs:main Jan 31, 2024
27 of 29 checks passed
@wzshiming wzshiming deleted the feat/heartbeat-factor branch January 31, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants