Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kwokctl] add dashboard-metrics-scraper #938

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[kwokctl] add dashboard-metrics-scraper #938

merged 1 commit into from
Jan 31, 2024

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Jan 30, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] add dashboard-metrics-scraper when have both dashboard and metrics-server

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 30, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 30, 2024 •
edited
Loading

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit 7718641
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/65b89f9e89adf800080ac8fc

@wzshiming wzshiming force-pushed the faet/dashboard-metrics-scraper branch from a61d3c4 to 98094f1 Compare January 30, 2024 05:10
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 30, 2024
@wzshiming wzshiming changed the title [kwokctl] add dashboard-metrics-scraper when have dashboard and metrics-server [kwokctl] add dashboard-metrics-scraper Jan 30, 2024
@wzshiming wzshiming force-pushed the faet/dashboard-metrics-scraper branch from 98094f1 to 33958a7 Compare January 30, 2024 07:03
@wzshiming wzshiming force-pushed the faet/dashboard-metrics-scraper branch from 33958a7 to 7718641 Compare January 30, 2024 07:05
@wzshiming wzshiming merged commit 24c7ebe into kubernetes-sigs:main Jan 31, 2024
27 of 29 checks passed
@wzshiming wzshiming deleted the faet/dashboard-metrics-scraper branch January 31, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzshiming @k8s-ci-robot