generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patches to instead of statusTemplate in Stage #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
kind/feature
Categorizes issue or PR as related to a new feature.
do-not-merge/release-note-label-needed
Indicates that a PR should not merge because it's missing one of the release note labels.
labels
Mar 4, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
kind/api-change
Categorizes issue or PR as related to adding, removing, or otherwise changing an API
label
Mar 4, 2024
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Mar 4, 2024
✅ Deploy Preview for k8s-kwok canceled.
|
k8s-ci-robot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Mar 4, 2024
wzshiming
force-pushed
the
feat/stage-api
branch
2 times, most recently
from
March 4, 2024 08:37
a51ed6c
to
8c4f226
Compare
k8s-ci-robot
added
kind/documentation
Categorizes issue or PR as related to documentation.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Mar 4, 2024
wzshiming
force-pushed
the
feat/stage-api
branch
6 times, most recently
from
March 5, 2024 08:57
9439f07
to
cd71594
Compare
wzshiming
changed the title
[WIP] Update Stage API
Add patches to instead of statusTemplate in Stage API
Mar 5, 2024
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Mar 5, 2024
wzshiming
force-pushed
the
feat/stage-api
branch
from
March 6, 2024 02:22
cd71594
to
269bdf2
Compare
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
and removed
do-not-merge/release-note-label-needed
Indicates that a PR should not merge because it's missing one of the release note labels.
labels
Mar 6, 2024
wzshiming
force-pushed
the
feat/stage-api
branch
2 times, most recently
from
March 6, 2024 05:43
0b020a4
to
d219a08
Compare
wzshiming
force-pushed
the
feat/stage-api
branch
from
March 18, 2024 08:40
d219a08
to
91d8ab6
Compare
wzshiming
force-pushed
the
feat/stage-api
branch
from
April 3, 2024 06:53
91d8ab6
to
ba0ccdb
Compare
wzshiming
changed the title
Add patches to instead of statusTemplate in Stage API
Add patches to instead of statusTemplate in Stage
Apr 3, 2024
wzshiming
force-pushed
the
feat/stage-api
branch
2 times, most recently
from
April 8, 2024 08:11
98c06a8
to
cd304a6
Compare
wzshiming
force-pushed
the
feat/stage-api
branch
from
April 18, 2024 02:06
cd304a6
to
b38a689
Compare
wzshiming
force-pushed
the
feat/stage-api
branch
from
April 18, 2024 05:50
018e1e8
to
c547675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/api-change
Categorizes issue or PR as related to adding, removing, or otherwise changing an API
kind/documentation
Categorizes issue or PR as related to documentation.
kind/feature
Categorizes issue or PR as related to a new feature.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref #922
Special notes for your reviewer:
kwok/pkg/apis/internalversion/conversion.go
Lines 394 to 447 in 60d7b64
Old Structure:
New Structure:
Examples:
Update a replicas through the 'scale' subresource
Update the 'status' but not is a subresource
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: