Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support CEL for matchExpressions #992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Support CEL for matchExpressions #992

wants to merge 1 commit into from

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Mar 11, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

xref #922

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support CEL for matchExpressions

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 11, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited
Loading

✅ Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit c658ac8
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/66d6d53019c6290008c26947
😎 Deploy Preview https://deploy-preview-992--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wzshiming wzshiming force-pushed the feat/match-conditions branch from 545bb9d to 8df7342 Compare March 11, 2024 11:01
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 11, 2024
@wzshiming wzshiming force-pushed the feat/match-conditions branch 4 times, most recently from 4a403b1 to 43e2340 Compare March 18, 2024 08:31
@wzshiming wzshiming force-pushed the feat/match-conditions branch from 43e2340 to 3a6d41e Compare April 1, 2024 07:20
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 1, 2024
@wzshiming wzshiming force-pushed the feat/match-conditions branch from 3a6d41e to 3f40dbb Compare April 8, 2024 08:04
@wzshiming wzshiming force-pushed the feat/match-conditions branch from 3f40dbb to d61dbfc Compare May 7, 2024 08:04
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@wzshiming wzshiming force-pushed the feat/match-conditions branch from d61dbfc to 0bd40f5 Compare August 6, 2024 10:02
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
@wzshiming wzshiming changed the title [WIP] Add matchConditions to Stage [WIP] Support CEL for matchExpressions Aug 6, 2024
@wzshiming wzshiming force-pushed the feat/match-conditions branch 3 times, most recently from 3fb8026 to 92122e2 Compare August 6, 2024 10:49
@wzshiming wzshiming force-pushed the feat/match-conditions branch from 92122e2 to 0b1dfe1 Compare August 6, 2024 11:14
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 6, 2024
@wzshiming wzshiming force-pushed the feat/match-conditions branch 8 times, most recently from 294bfa8 to b52e9b6 Compare August 30, 2024 03:33
@wzshiming wzshiming force-pushed the feat/match-conditions branch from b52e9b6 to c658ac8 Compare September 3, 2024 09:21
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzshiming @k8s-ci-robot @k8s-triage-robot