Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kwokctl] Add --kube-apiserver-insecure-port for create cluster #999

Merged

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented Mar 15, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[kwokctl] Add --kube-apiserver-insecure-port for create cluster

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 15, 2024
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for k8s-kwok ready!

Name Link
🔨 Latest commit 248ba5a
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/65f7f321db65210008d7d3ba
😎 Deploy Preview https://deploy-preview-999--k8s-kwok.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wzshiming wzshiming force-pushed the feat/foreground-insecure-cluster branch from 7ff449a to 793b9bd Compare March 18, 2024 07:35
@wzshiming wzshiming changed the title [kwokctl] Add --kube-apiserver-insecure-port and --foreground for create cluster [kwokctl] Add --kube-apiserver-insecure-port for create cluster Mar 18, 2024
@wzshiming wzshiming force-pushed the feat/foreground-insecure-cluster branch from 793b9bd to 0911dbe Compare March 18, 2024 07:38
@wzshiming wzshiming force-pushed the feat/foreground-insecure-cluster branch from 0911dbe to 248ba5a Compare March 18, 2024 07:54
@wzshiming wzshiming merged commit 864f788 into kubernetes-sigs:main Mar 26, 2024
26 of 27 checks passed
@wzshiming wzshiming deleted the feat/foreground-insecure-cluster branch March 26, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants