Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype some examples in existing components #2

Open
mtaufen opened this issue May 28, 2019 · 8 comments
Open

Prototype some examples in existing components #2

mtaufen opened this issue May 28, 2019 · 8 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mtaufen
Copy link
Contributor

mtaufen commented May 28, 2019

Now that the initial work has merged, we should prototype some examples in existing components and iterate on the library.

As I remember, kubeadm and kube-proxy have both been suggested as candidates for this. Would someone familiar with the code in those components like to give it a shot?

I'll probably take a crack at a kubelet at some point as well (though the next month+ is busy for me, as I'm in the middle of a move, so probably not until after that).

/cc @luxas @sttts @stealthybox @neolit123 @rosti

@stealthybox
Copy link

@alejandrox1, this may be a consumable task since you're diving into so much code.
It will involve understanding how flags are registered in an existing component.
@mtaufen suggests kubeadm and kube-proxy. I would probably recommend kube-proxy.

Once you understand the flag registration, we'd like to vendor in this lib if not already present and use it to standardize the approach for flags.

@mtaufen
Copy link
Contributor Author

mtaufen commented Jul 2, 2019

For folks looking at this, there is an old example PR based on a prior (but not that different) version of legacyflag that might be useful for reference: kubernetes/kubernetes#73494 (look in the staging/src/k8s.io/component-base/experimental/cli/kflag/example directory in that PR).

@alejandrox1
Copy link
Contributor

alejandrox1 commented Jul 2, 2019

Thank you for the reference @mtaufen
im currently working on a prototype for kube-proxy
/lifecycle active
/assign

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jul 2, 2019
@alejandrox1
Copy link
Contributor

/assign

@mtaufen
Copy link
Contributor Author

mtaufen commented Jul 3, 2019 via email

@rosti
Copy link

rosti commented Jul 5, 2019

I also started deliberating over this with kubeadm in mind, but so far it's mostly deliberation and very few LOC were actually written.
/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Oct 3, 2019
@mtaufen
Copy link
Contributor Author

mtaufen commented Oct 3, 2019

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants