-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype some examples in existing components #2
Comments
@alejandrox1, this may be a consumable task since you're diving into so much code. Once you understand the flag registration, we'd like to vendor in this lib if not already present and use it to standardize the approach for flags. |
For folks looking at this, there is an old example PR based on a prior (but not that different) version of legacyflag that might be useful for reference: kubernetes/kubernetes#73494 (look in the |
Thank you for the reference @mtaufen |
/assign |
Awesome! I'm happy to review it when you're ready.
…On Tue, Jul 2, 2019 at 4:42 PM Jorge Alarcon Ochoa ***@***.***> wrote:
/assign
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2?email_source=notifications&email_token=AAG4TQMZ3JDRMUGYZ2SBGO3P5PRXDA5CNFSM4HQESUO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZC3ARY#issuecomment-507883591>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAG4TQMGAC7EJEUINIUGTVDP5PRXDANCNFSM4HQESUOQ>
.
--
Michael Taufen
Google SWE
|
I also started deliberating over this with kubeadm in mind, but so far it's mostly deliberation and very few LOC were actually written. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Now that the initial work has merged, we should prototype some examples in existing components and iterate on the library.
As I remember, kubeadm and kube-proxy have both been suggested as candidates for this. Would someone familiar with the code in those components like to give it a shot?
I'll probably take a crack at a kubelet at some point as well (though the next month+ is busy for me, as I'm in the middle of a move, so probably not until after that).
/cc @luxas @sttts @stealthybox @neolit123 @rosti
The text was updated successfully, but these errors were encountered: