Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logcheck: allow klog.Format for contextual logging #17

Merged
merged 1 commit into from
May 9, 2023
Merged

logcheck: allow klog.Format for contextual logging #17

merged 1 commit into from
May 9, 2023

Conversation

pohly
Copy link
Contributor

@pohly pohly commented May 9, 2023

The new API call is useful also for contextual logging and thus allowed.

@pohly
logcheck: allow klog.Format for contextual logging
42ab091 
The new API call is useful also for contextual logging and thus allowed.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If logtools contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2023
@pohly
Copy link
Contributor Author

pohly commented May 9, 2023

See kubernetes/klog#374

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4ac3afd into kubernetes-sigs:main May 9, 2023
@SataQiu SataQiu mentioned this pull request May 11, 2023
Merged
@SataQiu
Copy link
Member

SataQiu commented May 11, 2023

Is there a plan to bump the version for k/k? @pohly

@pohly
Copy link
Contributor Author

pohly commented May 11, 2023

Yes, as soon as #15 is also merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@dims dims Awaiting requested review from dims

Assignees

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pohly @k8s-ci-robot @serathius @SataQiu