Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore controller-runtime upgrade #156

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

kerthcet
Copy link
Contributor

@kerthcet kerthcet commented May 31, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it

Which issue(s) this PR fixes

xref: #154

wait for open-policy-agent/cert-controller#207 to be fixed.

Special notes for your reviewer

Does this PR introduce a user-facing change?

None

Signed-off-by: kerthcet <kerthcet@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Jun 2, 2024

can we create an issue to track revering this?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 71279e6 into kubernetes-sigs:main Jun 2, 2024
7 checks passed
@kerthcet
Copy link
Contributor Author

kerthcet commented Jun 2, 2024

See #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants