Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.6] cherrypick #1300 kernel bug lead to incorrect cpu usage #1309

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[release-0.6] cherrypick #1300 kernel bug lead to incorrect cpu usage #1309

merged 1 commit into from
Aug 2, 2023

Conversation

yangjunmyfm192085
Copy link
Contributor

What this PR does / why we need it:
cherrypick #1300
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If metrics-server contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 2, 2023
@yangjunmyfm192085
Copy link
Contributor Author

/retest

@yangjunmyfm192085
Copy link
Contributor Author

/cc @serathius @dgrisonnet

serathius
serathius reviewed Aug 2, 2023
View reviewed changes
pkg/storage/types_test.go Outdated
name string
last MetricsPoint
prev MetricsPoint
resourceList v1.ResourceList
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
resourceList v1.ResourceList
wantResourceList v1.ResourceList

serathius
serathius reviewed Aug 2, 2023
View reviewed changes
pkg/storage/types_test.go Outdated
last MetricsPoint
prev MetricsPoint
resourceList v1.ResourceList
timeInfo api.TimeInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeInfo api.TimeInfo
wantTimeInfo api.TimeInfo

@yangjunmyfm192085
Copy link
Contributor Author

@serathius, I have applied all sugesstions, could you please take a look again? thanks.

@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 498d419 into kubernetes-sigs:release-0.6 Aug 2, 2023
8 checks passed
@dgrisonnet
Copy link
Member

I doubt we will ever cut v0.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yangjunmyfm192085 @k8s-ci-robot @serathius @dgrisonnet