-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow storage option in configmap #1500
allow storage option in configmap #1500
Conversation
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Welcome @kranurag7! |
Hi @kranurag7. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -13,5 +13,6 @@ data: | |||
baseCPU: {{ .Values.addonResizer.nanny.cpu }} | |||
cpuPerNode: {{ .Values.addonResizer.nanny.extraCpu }} | |||
baseMemory: {{ .Values.addonResizer.nanny.memory }} | |||
baseStorage: {{ .Values.addonResizer.nanny.storage }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supported in nannyconfig/v1alpha1
?
https://pkg.go.dev/k8s.io/autoscaler/addon-resizer/nanny/apis/nannyconfig#pkg-types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is missing. I think that means we shouldn't parse the following:
Base: resource.MustParse(*baseStorage),
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand your reply. I think you'll have to conditionally set command-line arguments for storage and extra-storage, because those don't seem to be supported by the config file. Might want to confirm with sig-autoscaling, as they are the owners for addon-resizer.
/assign @stevehipwell |
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @kranurag7 but I'm not sure as to why it's required? The log line you've quoted looks to be informational and is reporting that the resizer isn't monitoring for storage; which IMHO is the desired behaviour.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kranurag7 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
while running metrics-server with nanny enabled. I see the following logs:
metrics-server-nanny I0524 03:18:42.689332 1 pod_nanny.go:101] storage: MISSING, extra_storage: 0Gi
and I wanted to avoid this.I chose
10Mi
default value but that can be changed as well. Please feel free to suggest a new value.Ref: https://github.com/kubernetes/autoscaler/blob/cf606a1400d6e421d32349e25115b508382111ff/addon-resizer/main.go#L145-L167