Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifests to use multi arch image #492

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

serathius
Copy link
Contributor

As now manifests are part of release we are free to update them.

/cc @s-urbaniak

@k8s-ci-robot k8s-ci-robot requested a review from s-urbaniak April 9, 2020 17:16
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 9, 2020
@serathius serathius added this to the v0.3.7 milestone Apr 9, 2020
@serathius serathius added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 9, 2020
@serathius
Copy link
Contributor Author

/cc @loburm

@k8s-ci-robot k8s-ci-robot requested a review from loburm April 10, 2020 14:22
@serathius serathius mentioned this pull request Apr 11, 2020
10 tasks
@loburm
Copy link

loburm commented Apr 16, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
@serathius
Copy link
Contributor Author

/retest

As now manifests are part of release we are free to update manifests.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@serathius serathius merged commit d0bc9eb into kubernetes-sigs:master Apr 16, 2020
serathius added a commit that referenced this pull request Apr 17, 2020
sarandia added a commit to sarandia/kubernetes that referenced this pull request Apr 27, 2021
Bumping the metrics-server version to v0.3.7. In this version,
metrics-server started building multi-arch images. To properly support
non-amd64 nodes, we should bump the version and remove the -amd64 in the
image path. (kubernetes-sigs/metrics-server#492)

```release-note
metrics-server now uses v0.3.7 and supports multi-arch Kubernetes nodes.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants