Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor kubeletClient #527

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Refactor kubeletClient #527

merged 1 commit into from
Jun 8, 2020

Conversation

serathius
Copy link
Contributor

Move address resover into client and merge all config setup.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 28, 2020
@serathius
Copy link
Contributor Author

/cc @s-urbaniak

@serathius serathius force-pushed the refactor-kubeclient branch from ec48583 to e6c581a Compare May 1, 2020 11:00
@serathius
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2020
@s-urbaniak
Copy link
Contributor

lgtm module a rebase

@serathius serathius force-pushed the refactor-kubeclient branch from e6c581a to 86a8701 Compare June 8, 2020 16:57
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 8, 2020
@serathius serathius force-pushed the refactor-kubeclient branch from 86a8701 to 0d4e211 Compare June 8, 2020 17:25
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2020
@serathius serathius force-pushed the refactor-kubeclient branch from 0d4e211 to a5bf0e6 Compare June 8, 2020 17:30
@serathius
Refactor kubeletClient
8fa9300 
Move address resover into client and merge all config setup.
@serathius serathius force-pushed the refactor-kubeclient branch from a5bf0e6 to 8fa9300 Compare June 8, 2020 18:27
@serathius serathius merged commit b191055 into kubernetes-sigs:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kawych kawych Awaiting requested review from kawych

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serathius @k8s-ci-robot @s-urbaniak