Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm chart ci #820

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Conversation

stevehipwell
Copy link
Contributor

@stevehipwell stevehipwell commented Sep 10, 2021

This fixes the failing Release Chart GH action, it's likely that the chart linting might fail with this but it shouldn't matter.

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @stevehipwell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stevehipwell
To complete the pull request process, please assign s-urbaniak after the PR has been reviewed.
You can assign the PR to them by writing /assign @s-urbaniak in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 10, 2021
@stevehipwell
Copy link
Contributor Author

@serathius @s-urbaniak this should allow the Helm chart to be released once merged.

@stevehipwell
Copy link
Contributor Author

@serathius @s-urbaniak I'd suggest cancelling the CI for this as only CI config has been changed (plus a markdown comment) and one of the CI jobs is expected to fail and be ignored.

@serathius serathius merged commit e7016ff into kubernetes-sigs:master Sep 10, 2021
@stevehipwell stevehipwell deleted the fix-helm-chart-ci branch September 10, 2021 13:43
@Filirom1
Copy link

Hello,

It seems to be failing because of protected branch gh-pages:

Pushing to branch "gh-pages"
remote: error: GH006: Protected branch update failed for refs/heads/gh-pages.        
remote: error: 5 of 5 required status checks are expected.        
To https://github.com/kubernetes-sigs/metrics-server
 ! [remote rejected] HEAD -> gh-pages (protected branch hook declined)
error: failed to push some refs to 'https://github.com/kubernetes-sigs/metrics-server'
Error: exit status 1

@stevehipwell
Copy link
Contributor Author

@Filirom1 that's correct, for this release we have #822 to manually publish the index and gh-pages has now been un-protected for future releases.

@Filirom1
Copy link

Thanks, now it seems that there is no URL to download the chart in the index.yaml

@stevehipwell
Copy link
Contributor Author

Thanks @Filirom1 I managed to mess this up in my PR. @serathius PR incoming.

@stevehipwell
Copy link
Contributor Author

@Filirom1 could you try again now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants