-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix helm chart ci #820
Fix helm chart ci #820
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Hi @stevehipwell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stevehipwell The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@serathius @s-urbaniak this should allow the Helm chart to be released once merged. |
@serathius @s-urbaniak I'd suggest cancelling the CI for this as only CI config has been changed (plus a markdown comment) and one of the CI jobs is expected to fail and be ignored. |
Hello, It seems to be failing because of protected branch Pushing to branch "gh-pages"
remote: error: GH006: Protected branch update failed for refs/heads/gh-pages.
remote: error: 5 of 5 required status checks are expected.
To https://github.com/kubernetes-sigs/metrics-server
! [remote rejected] HEAD -> gh-pages (protected branch hook declined)
error: failed to push some refs to 'https://github.com/kubernetes-sigs/metrics-server'
Error: exit status 1 |
Thanks, now it seems that there is no URL to download the chart in the index.yaml |
Thanks @Filirom1 I managed to mess this up in my PR. @serathius PR incoming. |
@Filirom1 could you try again now? |
This fixes the failing Release Chart GH action, it's likely that the chart linting might fail with this but it shouldn't matter.