This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Handle multiple configurations of the same type in ConfigReconciler #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @adrianludwin |
yiqigao217
reviewed
Mar 23, 2020
sophieliu15
force-pushed
the
duplicate_types
branch
from
bbbc82a to
eeb066e
Compare
This PR handles multiple configurations for the same type in ConfigReconciler. If there are multiple configurations for the same type, only the first configuration will be followed, the rest will be ignored. Tested:unit tests, GKE cluster Issue: kubernetes-retired#411
sophieliu15
force-pushed
the
duplicate_types
branch
from
eeb066e to
bde8491
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, sophieliu15 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles multiple configurations of the same type in ConfigReconciler. If there are multiple configurations for the same type, only the first configuration will be followed, the rest will be ignored.
Tested:unit tests, GKE cluster
Issue: #411