-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Execution on Fedora 36 and Kubernetes v1.24.3 #109
Conversation
Signed-off-by: Justin Lamp <justin.lamp@netways.de>
Signed-off-by: Justin Lamp <justin.lamp@netways.de>
Welcome @modzilla99! |
Signed-off-by: Justin Lamp <justin.lamp@netways.de>
@kvaps sorry for pinging you, but any chance of this (or sth similar) getting merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for your contribution and sorry for late reply, changes looks good.
Could you update chart version from 1.5.0 to 1.6.0?
Hi @kvaps , @modzilla99 . Without this patch the nfs-ganesha will be OOMKilled installed with the latest helm chart. I've tested modzilla99:master by installing it in a cluster and running a pod with a mounted NFS share. Everything works smoothly. Could we merge it faster to avoid manual container build and make the installation easier? I could fork and apply required chart version change and create a new pull request if needed. |
7fc3e83
to
5420380
Compare
Signed-off-by: Justin Lamp <justin.lamp@netways.de>
Hey, I rebased and bumped the version to v1.6.0. Please tell me if I missed sth! /assign @kvaps Best regards, |
Signed-off-by: Justin Lamp <justin.lamp@netways.de>
I found that the problem was caused by a bad ulimit setting. If you change the cri base spec and set the ulimit to something smaller it will fix it (and mysql:5.7 as well). $ ctr oci spec | jq '.process.rlimits[0].soft=262144 | .process.rlimits[0].hard=524288' > /etc/containerd/cri-base.json
$ tail -n5 /etc/containerd/config.toml
[plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
# set default runtime handler to v2, which has a per-pod shim
runtime_type = "io.containerd.runc.v2"
# Generated by "ctr oci spec" and modified ulimits to fix OOMKills
base_runtime_spec = "/etc/containerd/cri-base.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kvaps, modzilla99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Great! Can you add the |
Yeah, I just waited for other PRs be merged, /lgtm thank you |
/lgtm |
@@ -8,7 +8,7 @@ replicaCount: 1 | |||
|
|||
image: | |||
repository: k8s.gcr.io/sig-storage/nfs-provisioner | |||
tag: v3.0.0 | |||
tag: v4.0.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skopeo list-tags docker://k8s.gcr.io/sig-storage/nfs-provisioner
{
"Repository": "k8s.gcr.io/sig-storage/nfs-provisioner",
"Tags": [
"v2.2.2",
"v3.0.0",
"v3.0.1"
]
}
With Fedora CoreOS 36 and Kubernetes v1.24.3 the container hangs in a CrashLoopBackoff and has to be OOM-killed by the kernel.
With a rebase on F36 and the latest ganesha, the problem is gone.