-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): allow configuration of k8s scheduling priority #82
feat(chart): allow configuration of k8s scheduling priority #82
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @joshuasimon-taulia! |
"I signed it" |
@@ -117,6 +117,9 @@ spec: | |||
tolerations: | |||
{{- toYaml . | nindent 8 }} | |||
{{- end }} | |||
{{- with .Values.priorityClass.name }} | |||
priorityClassName: {{ toYaml . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I guess one could use toYaml on a string. I had not considered that before. I'd do something like this typically -because it can be relevant to make it quoted if the name would be for example the string "5", but toYaml .
would also do the trick.
priorityClassName: "{{ . }}"
priorityClassName: {{ . | quote }}
@joshuasimon-taulia I'm curious, have used this practice intentionally in favor of the practices I'm used to in this or other helm charts before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was the result of copy/paste. i pushed an update
c719f90
to
46e7074
Compare
1db5174
to
801f148
Compare
a4faa8e
to
b765e79
Compare
2f90c7e
to
6fb6d44
Compare
fix: quote priorityClassName Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com> fix: default priorityClass name to .fullname Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com> fix: default priorityClass name to .fullname Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com> Update charts/nfs-server-provisioner/templates/statefulset.yaml Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com> chore: bump chart version Update charts/nfs-server-provisioner/templates/statefulset.yaml Co-authored-by: Andrei Kvapil <kvapss@gmail.com>
6fb6d44
to
42c3923
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joshuasimon-taulia, kvaps The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
can someone hit me with a /lgtm |
/lgtm |
allow creation or use of existing k8s priorityClass. the idea is to have the nfs-server-provisioner up and running before workloads that depend on it. see https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/