-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt the Helm Chart from the deprecated repository #30
Conversation
Files are as is from deprecated repo
@yonatankahana would it be possible to add helm index directly to this repo, so that people are still able to trigger helm install withouth the need to clone git repo itself? Or is there any plan to provide "add repo" support? |
Yes, It it possible but not necessarily the best option, especially in the scope of this PR. My idea was to first bring it here and then, in a separate PR, we can automate the release process and consider where to host the packaged chart. |
@wongma7 @jsafrane @kmova @jackielii @ashishranjan738 any of you have time to take a look? Thanks! ❤️ |
Would the migration from |
yes. |
I agree with this approach. In future it should be automated with github actions, for now at least the chart has to be imported into the repo. |
/lgtm |
- name: nfs-subdir-external-provisioner-root | ||
{{- if .Values.buildMode }} | ||
emptyDir: {} | ||
{{- else if .Values.nfs.mountOptions }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kmova, yonatankahana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adopt the Helm Chart from the deprecated repository
What is this PR
The latest official helm chart is in the old and deprecated repository and not currently being maintained. This chart uses very old image and soon (i hope) we will publish newer images and we will need to update the chart accordingly with the new features available (such as #20). To be ready for that we first need to bring it home.
Changes besides just copy and paste the old chart:
Notice to reviewer
This PR consist of 2 commits, the first commit brings the chart AS-IS from the old repository, and the second commit shows my changes since then.
I did this to make the review process easier because most of the files not modified. Once we are ready to merge I will squash them into single commit if required.