Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable codecov reporting #1033

Closed
marquiz opened this issue Jan 16, 2023 · 11 comments · Fixed by #1069
Closed

Enable codecov reporting #1033

marquiz opened this issue Jan 16, 2023 · 11 comments · Fixed by #1069
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@marquiz
Copy link
Contributor

marquiz commented Jan 16, 2023

What would you like to be added:

Now that kubernetes/org#3084 has been solved, we could enable codecov reporing in NFD. We should probably separate unit tests from the image build (Dockerfile) into a distinct prow job. An outline of sub-tasks (might be missing some)

  1. Enable coverage output in Makefile test: target
  2. Add new presubmit-test Prow job
  3. Get codecov token added as a secret in the k8s test-infra cluster
  4. Add codecov reporting in the NFD test-infra script (``scripts/test-infra/`)

Why is this needed:

Improve development process

@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 16, 2023
@fmuyassarov
Copy link
Member

+1 for the codecov and I guess it makes sense to decouple the unit tests from the Dockerfile into its own job.

@ArangoGutierrez
Copy link
Contributor

+1

@fmuyassarov
Copy link
Member

@marquiz do you plan to work on this ?

@marquiz
Copy link
Contributor Author

marquiz commented Feb 2, 2023

@marquiz do you plan to work on this ?

Feel free to help out here 😉 TBH, I don't know if I have time to take care of this in the near future

@AhmedGrati
Copy link

@marquiz I can work on it once I finish my current PR.

@fmuyassarov
Copy link
Member

Hi @AhmedGrati. Thanks for offering help. But I had it halfway. If you don't mind let me finish it and if I don't for some reason I will let you know here.
/assign

@marquiz
Copy link
Contributor Author

marquiz commented Mar 7, 2023

I don't think we're quite ready yet
/reopen

@k8s-ci-robot k8s-ci-robot reopened this Mar 7, 2023
@k8s-ci-robot
Copy link
Contributor

@marquiz: Reopened this issue.

In response to this:

I don't think we're quite ready yet
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ArangoGutierrez
Copy link
Contributor

I think we are ready here, right @fmuyassarov

@fmuyassarov
Copy link
Member

I believe yes. This is done via #1201, #1200, #1199, #1194, #1095, #1085, #1069.
/close

@k8s-ci-robot
Copy link
Contributor

@fmuyassarov: Closing this issue.

In response to this:

I believe yes. This is done via #1201, #1200, #1199, #1194, #1095, #1085, #1069.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants