-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable codecov reporting #1033
Comments
+1 for the codecov and I guess it makes sense to decouple the unit tests from the Dockerfile into its own job. |
+1 |
@marquiz do you plan to work on this ? |
Feel free to help out here 😉 TBH, I don't know if I have time to take care of this in the near future |
@marquiz I can work on it once I finish my current PR. |
Hi @AhmedGrati. Thanks for offering help. But I had it halfway. If you don't mind let me finish it and if I don't for some reason I will let you know here. |
I don't think we're quite ready yet |
@marquiz: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think we are ready here, right @fmuyassarov |
@fmuyassarov: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What would you like to be added:
Now that kubernetes/org#3084 has been solved, we could enable codecov reporing in NFD. We should probably separate unit tests from the image build (Dockerfile) into a distinct prow job. An outline of sub-tasks (might be missing some)
test:
targetpresubmit-test
Prow jobscripts/test-infra/
make test
from Dockerfile(?)Why is this needed:
Improve development process
The text was updated successfully, but these errors were encountered: