Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Community CI By August 1st #1747

Closed
BenTheElder opened this issue Jun 21, 2024 · 13 comments
Closed

Migrate to Community CI By August 1st #1747

BenTheElder opened this issue Jun 21, 2024 · 13 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@BenTheElder
Copy link
Member

Node feature discovery CI still needs migrating, per https://groups.google.com/a/kubernetes.io/g/dev/c/p6PAML90ZOU

You can find jobs listed in:

https://github.com/kubernetes/test-infra/blob/master/docs/job-migration-todo.md

(see e.g. jobs with name containing "node-feature-discovery")

@BenTheElder BenTheElder added the kind/bug Categorizes issue or PR as related to a bug. label Jun 21, 2024
@ArangoGutierrez ArangoGutierrez self-assigned this Jul 2, 2024
@ArangoGutierrez
Copy link
Contributor

kubernetes/test-infra#32887

@ArangoGutierrez
Copy link
Contributor

kubernetes/test-infra#32887 Merged!
/close

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: Closing this issue.

In response to this:

kubernetes/test-infra#32887 Merged!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder
Copy link
Member Author

You should probably double check that the e2e job is still working, in particular, it might need some follow-ups.

@ArangoGutierrez
Copy link
Contributor

You should probably double check that the e2e job is still working, in particular, it might need some follow-ups.

you are right, celebrating too fast....
/reopen

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: Reopened this issue.

In response to this:

You should probably double check that the e2e job is still working, in particular, it might need some follow-ups.

you are right, celebrating too fast....
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot reopened this Jul 2, 2024
@BenTheElder
Copy link
Member Author

since it's a postsubmit, we won't know until a PR merges.

I could manually trigger it to run again for an existing merge but with the latest config, let's try that ...

@BenTheElder
Copy link
Member Author

@BenTheElder
Copy link
Member Author

If we check the events for the failed run:

Error: secret "node-feature-discovery-ci" not found

Whatever this secret was enabling will need to be replicated using only what is provided by the k8s community infra.

I don't have context on what this job attempts to do and why it had a custom secret. Does anyone know what this secret was for?

If it's just to use a GCP project, you can instead rent one from boskos, kubetest(2) provide facilities for this.

it actually kinda looks like https://github.com/kubernetes-sigs/node-feature-discovery/blob/master/scripts/test-infra/test-e2e.sh is doing things on AWS?

@BenTheElder
Copy link
Member Author

in which case we should move it to the EKS cluster and figure out how to replicate the infra over there (not my speciality but .. we can reach out in #sig-k8s-infra)

@marquiz
Copy link
Contributor

marquiz commented Jul 9, 2024

#1763 is the last bit

@ArangoGutierrez
Copy link
Contributor

#1763 is the last bit

Merged!
we are good to close this @BenTheElder

@BenTheElder
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants