nfd-master: add validation of label names and values

[marquiz]

Validate labels before trying to update the node. Makes us fail early nad prevent useless retries in case invalid labels are tried.

[netlify]

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name	Link
🔨 Latest commit	2a3c7e4
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/6474aea60fa7710008e6c287
😎 Deploy Preview	https://deploy-preview-1228--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[marquiz]

/assign @PiotrProkop
/cherrypick release-0.13

[k8s-infra-cherrypick-robot]

@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.13 in a new PR and assign it to you.

In response to this:

/assign @PiotrProkop
/cherrypick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ArangoGutierrez]

/test all

[PiotrProkop]

I think we can experience -> kubernetes/test-infra#29622

[marquiz]

/retest

[marquiz]

/assign @ArangoGutierrez

[ArangoGutierrez]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 7db8a7d55c46048b0c0f47e35309aaba69bb5407

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #1228 (2a3c7e4) into master (7d71510) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
+ Coverage   28.66%   28.72%   +0.05%     
==========================================
  Files          51       51              
  Lines        7165     7171       +6     
==========================================
+ Hits         2054     2060       +6     
  Misses       4898     4898              
  Partials      213      213              

Impacted Files	Coverage Δ
pkg/nfd-master/nfd-master.go	42.02% <100.00%> (+0.39%)	⬆️

[k8s-infra-cherrypick-robot]

@marquiz: #1228 failed to apply on top of branch "release-0.13":

Applying: nfd-master: add validation of label names and values
Using index info to reconstruct a base tree...
M	pkg/nfd-master/nfd-master-internal_test.go
M	pkg/nfd-master/nfd-master.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/nfd-master/nfd-master.go
CONFLICT (content): Merge conflict in pkg/nfd-master/nfd-master.go
Auto-merging pkg/nfd-master/nfd-master-internal_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 nfd-master: add validation of label names and values
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/assign @PiotrProkop
/cherrypick release-0.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.