-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deployment/helm: fix namespace of nfd-worker role and rolebinding #1364
deployment/helm: fix namespace of nfd-worker role and rolebinding #1364
Conversation
Put nfd-worker role and rolebinding in the correct namespace if namespaceOverride parameter is used.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cherry-pick release-0.13 |
@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1364 +/- ##
=======================================
Coverage 30.02% 30.02%
=======================================
Files 56 56
Lines 7457 7457
=======================================
Hits 2239 2239
Misses 4974 4974
Partials 244 244 |
/cherry-pick release-0.14 |
@marquiz: once the present PR merges, I will cherry-pick it on top of release-0.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 7115370e0b06153b7f0fded80c5af528a7d58a10
|
@marquiz: new pull request created: #1369 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@marquiz: new pull request created: #1370 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Put nfd-worker role and rolebinding in the correct namespace if namespaceOverride parameter is used.
Fixes: #1363