Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm - Move remaining gPRC related flags to conditional #1387

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Helm - Move remaining gPRC related flags to conditional #1387

merged 1 commit into from
Oct 3, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

This patch continues to clean up after gRPC deprecation, by moving remaining flags in Helm charts under conditional of enableNodeFeatureAPI being set to false

@ArangoGutierrez
Helm - Move remaining gPRC related flags to conditional
3543aa2 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 3543aa2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/651ba7d9c8893a00080c93c8
😎 Deploy Preview https://deploy-preview-1387--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2023
marquiz
marquiz approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez.
/lgtm

A further enhancement: make the creation of the Service (templates/service.yaml) conditional, too.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 607859ad3aa92b7e54a579b0733225a1c9f908b9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1387 (3543aa2) into master (076ed3c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1387   +/-   ##
=======================================
  Coverage   30.02%   30.02%           
=======================================
  Files          56       56           
  Lines        7457     7457           
=======================================
  Hits         2239     2239           
  Misses       4974     4974           
  Partials      244      244

@k8s-ci-robot k8s-ci-robot merged commit 4ad6491 into kubernetes-sigs:master Oct 3, 2023
5 checks passed
@ArangoGutierrez
Copy link
Contributor Author

Thanks @ArangoGutierrez.
/lgtm

A further enhancement: make the creation of the Service (templates/service.yaml) conditional, too.

Will do!

@marquiz marquiz mentioned this pull request Dec 20, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@AhmedGrati AhmedGrati Awaiting requested review from AhmedGrati

@jjacobelli jjacobelli Awaiting requested review from jjacobelli

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz