-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running together with metrics-server #561
Comments
I couldn't find the source for this. But IIRC I don't think you're supposed to run both. You can remove metrics-server and keep using prometheus-adapter as it covers the functionality of the metrics-server. Pls correct me if I'm wrong. |
I understand it same, the adapter should provide the functionality of the metrics-server plus custom and external metrics support. It sucks that To be even more complicated we also use Datadog with external metrics which in turn clashes about |
It should work? (If prometheus-adapter is installed afterwards). |
/triage accepted |
Yeah if you have configured resource metrics, it should work.
There is an effort that was started a while ago but didn't make much progress, to support multiple external metrics providers: kubernetes-sigs/custom-metrics-apiserver#70. But if you use both Prometheus and Datadog metrics for autoscaling I would recommand KEDA: https://github.com/kedacore/keda. It is a CNCF project that support autoscaling on both datasources and many more. |
/kind support |
The problem is we use ArgoCD that constantly reconciles the deployments hence if we have |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
Sorry we didn't get to this. If this is still affecting you, feel free to reopen. |
@dashpole: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dashpole This is still a thing, can you reopen? |
I feel like this should remain closed as I have already shared the current initiative that would fix your issue and a potential alternative you could use in the meantime. There is nothing more that can be done. As I mentioned before there are three ways to go about the problem:
|
What happened?:
After deploying
prometheus-adapter
In a cluster where I havemetrics-server
running I get a clash around theAPIService/v1beta1.metrics.k8s.io
resource as it seems being created by both. Do we need to removemetrics-server
before installingprometheus-adapter
?Environment:
v4.1.1
v15.9.0
kubectl version
): EKSv1.22
The text was updated successfully, but these errors were encountered: