Fix kpromo version in cloudbuild job #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git files are exuded by default in Google Cloud build, which means that
we have no kpromo `GitVersion`/`GitCommit`available in:
```
> podman run -it registry.k8s.io/artifact-promoter/kpromo:v3.5.2-0 version
_ __ ____ ____ ___ __ __ ___
| |/ / | _ \ | _ \ / _ \ | \/ | / _ \
| ' / | |_) | | |_) | | | | | | |\/| | | | | |
| . \ | __/ | _ < | |_| | | | | | | |_| |
|_|\_\ |_| |_| \_\ \___/ |_| |_| \___/
kpromo: Kubernetes project artifact promoter
GitVersion:
GitCommit:
GitTreeState: clean
BuildDate: 2023-04-05T20:43:02Z
GoVersion: go1.19.8
Compiler: gc
Platform: linux/amd64
```
Means we also have this information not available in the signatures:
```
> cosign verify \
--certificate-identity krel-trust@k8s-releng-prod.iam.gserviceaccount.com \
--certificate-oidc-issuer https://accounts.google.com \
registry.k8s.io/security-profiles-operator/security-profiles-operator:v0.8.0 | jq '.[0].optional."org.kubernetes.kpromo.version"'
…
"kpromo-"
```
This is now fixed by using an empty `.gcloudignore` file.
This commit also fixes to print the correct build step in the
`go_with_version` script.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
git files are exuded by default in Google Cloud build, which means that we have no kpromo
GitVersion/GitCommitavailable in:Means we also have this information not available in the signatures:
This is now fixed by using an empty
.gcloudignorefile.This commit also fixes to print the correct build step in the
go_with_versionscript.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?