Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to use go1.20 and fix lints #863

Merged
merged 1 commit into from
May 10, 2023
Merged

upgrade to use go1.20 and fix lints #863

merged 1 commit into from
May 10, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 10, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

  • upgrade to use go1.20 and fix lints

Need test-infra PR to use the jobs to set go to 1.20 - kubernetes/test-infra#29478

/assign @saschagrunert @puerco @xmudrii
cc @kubernetes-sigs/release-engineering
/hold

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

upgrade to use go1.20 and fix lints

@cpanato
upgrade to use go1.20 and fix lints
8f5e9ea 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 10, 2023
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 10, 2023
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2023
@cpanato cpanato mentioned this pull request May 10, 2023
Merged
saschagrunert
saschagrunert reviewed May 10, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still complains that

go: go.mod file indicates go 1.20, but maximum version supported by tidy is 1.19

@cpanato
Copy link
Member Author

cpanato commented May 10, 2023

/test pull-cip-verify

@cpanato
Copy link
Member Author

cpanato commented May 10, 2023

It still complains that

go: go.mod file indicates go 1.20, but maximum version supported by tidy is 1.19

all good now

@cpanato
Copy link
Member Author

cpanato commented May 10, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2023
@ameukam
Copy link
Member

ameukam commented May 10, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6857ea7 into kubernetes-sigs:main May 10, 2023
@cpanato cpanato deleted the update-go branch May 10, 2023 16:38
@xmudrii xmudrii mentioned this pull request May 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@jimangel jimangel Awaiting requested review from jimangel

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@saschagrunert saschagrunert

@ameukam ameukam

@puerco puerco

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cpanato @k8s-ci-robot @ameukam @saschagrunert @puerco @xmudrii