Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a presubmit job triggered builds on draft pull requests #190

Open
ivanvc opened this issue Jun 12, 2024 · 0 comments
Open

Renaming a presubmit job triggered builds on draft pull requests #190

ivanvc opened this issue Jun 12, 2024 · 0 comments

Comments

@ivanvc
Copy link

ivanvc commented Jun 12, 2024

Background Slack threads: #sig-testing, #prow.

As part of etcd's migration to the prow infrastructure, I recently renamed an etcd presubmit job (pull-etcd-unit-test to pull-etcd-unit-test-amd64) in kubernetes/test-infra#32708. After merging this pull request, it triggered jobs in many pull requests.

However, it seems like the status reconciler may have a bug, as it also ran on draft pull requests. An example is etcd-io/etcd#14094: prow job

Here's the list of the jobs it ran; the ones before Jun 05 17:20:00 were automatically triggered after the renaming:
https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-etcd-unit-test-amd64?buildId=1798872340767969280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant