Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcd presubmit unit test jobs #32708

Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jun 5, 2024

Update the current pull-etcd-unit-test job: adjust its memory based on Grafana, rename it to add the 386 job, update its running parameters, and store the JUnit results in Prow artifacts.

Add the 386 job moving forward with the Prow infra migration.

* Rename job to pull-etcd-unit-test-amd64.
* Tune the resources requested/limits according to job runs on Grafana.
* Update running arguments to match the current GitHub workflow.
* Store output JUnit artifacts.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jmhbnz June 5, 2024 22:45
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Jun 5, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 5, 2024
- -c
- |
export JUNIT_REPORT_DIR=${ARTIFACTS}
GOOS=linux GOARCH=386 CPU=1 GO_TEST_FLAGS='-p=4' make test-unit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are limiting to once CPU here should we also update requests/limits for the pod to 1 CPU?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it with what the original import to Prow had. Notice that it has optional: true, as I'm monitoring these jobs and adjusting resources after some runs. Based on my observations from the integration tests, even when limited to one CPU, it may consume a bit more, especially at the beginning of the job.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, let's leave it as is and tune later as needed :)

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @ivanvc

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 23d8538 into kubernetes:master Jun 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ivanvc: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

Update the current pull-etcd-unit-test job: adjust its memory based on Grafana, rename it to add the 386 job, update its running parameters, and store the JUnit results in Prow artifacts.

Add the 386 job moving forward with the Prow infra migration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc ivanvc deleted the update-etcd-presubmit-unit-test-jobs branch June 5, 2024 23:30
@ivanvc
Copy link
Member Author

ivanvc commented Jun 6, 2024

Linking to kubernetes/k8s.io#6102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants