Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor publish-release action to install only or run it with options #69

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 19, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2024
@cpanato cpanato force-pushed the refactor-publish-release branch 3 times, most recently from f7cdde0 to f42b428 Compare April 19, 2024 12:33
@cpanato cpanato force-pushed the refactor-publish-release branch from f42b428 to eb875a3 Compare April 19, 2024 12:35
@cpanato
Copy link
Member Author

cpanato commented Apr 19, 2024

/assign @puerco
did a refactor and now we just need one action, that we can run the entire flow as before or just install it

PTAL

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2024
@saschagrunert
Copy link
Member

/hold

for @puerco

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @cpanato !
I want to factor out some of the bash code that deals with downloads and verification into something more reusable because I feel we have that repeated everywhere. I am slowly working on something which you will hate, of course, but maybe will show you what I mean :)

I am merging this now, will removing the existing actions break other projects if @dependabot bumps them?

/hold cancel

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, puerco, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,puerco,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Apr 22, 2024

/lgtm

Thanks @cpanato ! I want to factor out some of the bash code that deals with downloads and verification into something more reusable because I feel we have that repeated everywhere. I am slowly working on something which you will hate, of course, but maybe will show you what I mean :)

I am merging this now, will removing the existing actions break other projects if @dependabot bumps them?

/hold cancel

/hold cancel

we will need to do manually

@k8s-ci-robot k8s-ci-robot merged commit 2cfd13f into kubernetes-sigs:main Apr 23, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants