Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update zeitgeist and add option to install local or remote releases #74

Merged
merged 1 commit into from
Apr 30, 2024
Merged

update zeitgeist and add option to install local or remote releases #74

merged 1 commit into from
Apr 30, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 30, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2024
@cpanato cpanato force-pushed the update-zeitgeist branch 4 times, most recently from f1f085f to 65b94e7 Compare April 30, 2024 11:44
@cpanato cpanato marked this pull request as ready for review April 30, 2024 11:45
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@cpanato
Copy link
Member Author

cpanato commented Apr 30, 2024

/assign @saschagrunert @puerco @xmudrii

saschagrunert
saschagrunert reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, otherwise LGTM

.github/workflows/test-setup-zeitgeist.yml Outdated Show resolved Hide resolved
@cpanato cpanato requested a review from saschagrunert April 30, 2024 12:15
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c80dfe7 into kubernetes-sigs:main Apr 30, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

@Verolop Verolop Awaiting requested review from Verolop

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

Assignees

@saschagrunert saschagrunert

@puerco puerco

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cpanato @k8s-ci-robot @saschagrunert @puerco @xmudrii