Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Context to scheduler plugins #664

Open
zwpaper opened this issue Nov 15, 2023 · 8 comments
Open

Provide Context to scheduler plugins #664

zwpaper opened this issue Nov 15, 2023 · 8 comments
Milestone

Comments

@zwpaper
Copy link
Member

zwpaper commented Nov 15, 2023

The general idea would be use context wherever you can:

  1. the chained calls in PreFitler/Filter can use the context that is provided by scheduler framework
  2. for calls outside PreFilter/Filter/..., we should instantiate one at the start of main() (or make some change in scheduler framework to expose it), and pass it to all plugins

Originally posted by @Huang-Wei in #655 (comment)

/kind enhancement

@k8s-ci-robot
Copy link
Contributor

@zwpaper: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

       The general idea would be use context wherever you can:
  1. the chained calls in PreFitler/Filter can use the context that is provided by scheduler framework
  2. for calls outside PreFilter/Filter/..., we should instantiate one at the start of main() (or make some change in scheduler framework to expose it), and pass it to all plugins

Originally posted by @Huang-Wei in #655 (comment)

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ffromani
Copy link
Contributor

/cc

@Huang-Wei Huang-Wei added this to the v1.28 milestone Nov 16, 2023
@lianghao208
Copy link
Member

To enhance the scheduler framework, do we need to introduce a new parameter into PluginFactory function in k/k framework/runtime/registry.go? so that we can instantiate each plugin with one consolidate context.

@Huang-Wei
Copy link
Contributor

To enhance the scheduler framework, do we need to introduce a new parameter into PluginFactory function in k/k framework/runtime/registry.go?

Yes, that would be an ideal way. I noticed this has been implemented - as a by-product of 116884 (in v1.29)

@Huang-Wei
Copy link
Contributor

Huang-Wei commented Nov 18, 2023

Changing milestone to v1.29.

@Huang-Wei Huang-Wei modified the milestones: v1.28, v1.29 Nov 18, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2024
@zwpaper
Copy link
Member Author

zwpaper commented Feb 17, 2024

let me have a look at it in following days

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2024
@han-so1omon
Copy link

han-so1omon commented May 3, 2024

new contributor. gonna take a look as well. @zwpaper if you already have a solution let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants