-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coscheduling: Remove the postBind filter in the KubeSchedulerConfiguration #672
Coscheduling: Remove the postBind filter in the KubeSchedulerConfiguration #672
Conversation
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
…ation Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2fa5902
to
7957ac0
Compare
I think that it would be better to cherry-pick this to the release-0.26 and release-0.27 branches. |
Actually specifying a non-existent extension point would fail scheduler's startup. But yes, let's fix the documents. And, we should turn to using /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That makes sense. |
/cherry-pick release-0.26 |
…emotes-upstream-release-1.27 Automated cherry pick of #672: Coscheduling: Remove the postBind filter in the
…emotes-upstream-release-1.26 Automated cherry pick of #672: Coscheduling: Remove the postBind filter in the
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I removed the PostBind filter in the KubeSchedulerConfiguration because the PostBind filter was removed in the #554.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?