Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coscheduling: Remove the postBind filter in the KubeSchedulerConfiguration #672

Merged

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Nov 18, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I removed the PostBind filter in the KubeSchedulerConfiguration because the PostBind filter was removed in the #554.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 18, 2023
Copy link

netlify bot commented Nov 18, 2023

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 7957ac0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/6558232f1997d800076f1bf5

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 18, 2023
@tenzen-y tenzen-y changed the title Coscheduling: Remove the podBind filter in the KubeSchedulerConfiguration Coscheduling: Remove the postBind filter in the KubeSchedulerConfiguration Nov 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2023
…ation

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the remove-podsBind-from-manaifest branch from 2fa5902 to 7957ac0 Compare November 18, 2023 02:36
@tenzen-y
Copy link
Member Author

I think that it would be better to cherry-pick this to the release-0.26 and release-0.27 branches.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 18, 2023
@Huang-Wei
Copy link
Contributor

I think that it would be better to cherry-pick this to the release-0.26 and release-0.27 branches.

Actually specifying a non-existent extension point would fail scheduler's startup. But yes, let's fix the documents. And, we should turn to using MultiPoint to simplify the scheduler config.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit ffba3d3 into kubernetes-sigs:master Nov 18, 2023
10 checks passed
@tenzen-y
Copy link
Member Author

I think that it would be better to cherry-pick this to the release-0.26 and release-0.27 branches.

Actually specifying a non-existent extension point would fail scheduler's startup. But yes, let's fix the documents. And, we should turn to using MultiPoint to simplify the scheduler config.

/lgtm /approve

That makes sense.

@tenzen-y
Copy link
Member Author

/cherry-pick release-0.26

@tenzen-y tenzen-y deleted the remove-podsBind-from-manaifest branch November 18, 2023 19:20
k8s-ci-robot added a commit that referenced this pull request Nov 18, 2023
…emotes-upstream-release-1.27

Automated cherry pick of #672: Coscheduling: Remove the postBind filter in the
k8s-ci-robot added a commit that referenced this pull request Nov 19, 2023
…emotes-upstream-release-1.26

Automated cherry pick of #672: Coscheduling: Remove the postBind filter in the
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants