Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add releasing helm chart #692

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Dec 28, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

release a helm chart when creating a tag/release as artifact, then we would host our helm chart repo on netlify page

Which issue(s) this PR fixes:

Fixes #607

Special notes for your reviewer:

this will create the helm chart as release artifact when creating v-prefix releases.

But I was thinking, the chart may change more frequently, maybe we should create some helm-chart-v-prefix releases?

Does this PR introduce a user-facing change?

release helm chart as artifact

Signed-off-by: Wei Zhang <kweizh@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 28, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 28, 2023
Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for kubernetes-sigs-scheduler-plugins ready!

Name Link
🔨 Latest commit ab0b214
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/658dae8747713e000851faec
😎 Deploy Preview https://deploy-preview-692--kubernetes-sigs-scheduler-plugins.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 28, 2023
@Huang-Wei
Copy link
Contributor

But I was thinking, the chart may change more frequently, maybe we should create some helm-chart-v-prefix releases?

Let's stick to tag name for now, and change if needed in the future.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, zwpaper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 301f804 into kubernetes-sigs:master Jan 4, 2024
10 checks passed
@fg91 fg91 mentioned this pull request Apr 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should host the helm chart on our github page
3 participants